Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace short field names with more descriptive ones. #937

Merged
merged 1 commit into from Mar 16, 2024

Conversation

matejrisek
Copy link
Contributor

@matejrisek matejrisek commented Nov 19, 2023

The decision to change the name of these fields came from reading the code further down in the scope and not being clear what c.c means.

This also aligns it with the convention from other structs in the same file like e.g. the session struct:

type session struct {
	auth     AuthMethod
	client   *http.Client
	endpoint *transport.Endpoint
	advRefs  *packp.AdvRefs
}

The decision to change the name of these fields came from reading the code
further down in the scope and not being clear what `c.c` means.
Copy link
Member

@pjbgf pjbgf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @matejrisek! 🙇

@pjbgf pjbgf merged commit feaeb36 into go-git:master Mar 16, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants