Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlogged error in ssh/common.go #185

Closed
cep21 opened this issue Oct 13, 2020 · 1 comment
Closed

Unlogged error in ssh/common.go #185

cep21 opened this issue Oct 13, 2020 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@cep21
Copy link

cep21 commented Oct 13, 2020

The file ssh/common.go contains the following code

func (r *runner) Command(cmd string, ep *transport.Endpoint, auth transport.AuthMethod) (common.Command, error) {
	c := &command{command: cmd, endpoint: ep, config: r.config}
	if auth != nil {
		c.setAuth(auth)
	}

	if err := c.connect(); err != nil {
		return nil, err
	}
	return c, nil
}

The setAuth function returns an error, but any error returned is not logged or returned to the client. This can make it difficult to customize the auth function of the library since users will be unaware their custom auth is not used.

Copy link

To help us keep things tidy and focus on the active tasks, we've introduced a stale bot to spot issues/PRs that haven't had any activity in a while.

This particular issue hasn't had any updates or activity in the past 90 days, so it's been labeled as 'stale'. If it remains inactive for the next 30 days, it'll be automatically closed.

We understand everyone's busy, but if this issue is still important to you, please feel free to add a comment or make an update to keep it active.

Thanks for your understanding and cooperation!

@github-actions github-actions bot added the stale Issues/PRs that are marked for closure due to inactivity label Dec 13, 2023
@pjbgf pjbgf added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed and removed stale Issues/PRs that are marked for closure due to inactivity labels Dec 13, 2023
@pjbgf pjbgf closed this as completed in ced1b81 Dec 14, 2023
pjbgf added a commit that referenced this issue Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants