feat: add hook-timeout to run and renew commands #2389
Merged
+19
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Boss Marco <bossm8@hotmail.com>
ldez
approved these changes
Jan 3, 2025
There was a problem hiding this comment.
Thank you 👍
Thank you for adding your use case, this is appreciated ❤️
I changed the type to use a duration: the syntax is more accurate because the need is more related to minutes (ex: 3m) than seconds (ex: 180).
Note: when you create a PR, it is better to use a dedicated branch instead of the main branch of the fork.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the option
--run-hook-timeoutand--renewal-hook-timeoutwhich lets you configure how long lego should wait for the hook to finish. The default of120seconds may be too short in some cases.Background:
We have a setup in which we run lego periodically with a systemd service/timer combo.
When we execute the run/renewal hook we have multiple tasks which we would execute with the hook script, those tasks may in some cases exceed the 120s timeout. The option added in this PR lets us configure this timeout and successfully finish all tasks with the script.