Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 0.29.0.gfm.11 #236

Merged
merged 6 commits into from Apr 11, 2023

Conversation

anticomputer
Copy link
Contributor

No description provided.

@kivikakk kivikakk self-assigned this Apr 1, 2023
@kivikakk
Copy link
Collaborator

kivikakk commented Apr 1, 2023

I've pushed a commit to fix the HtmlRenderer output no longer conforming to cmark-gfm, but there's one remaining failure which reflects a newly introduced bug in cmark-gfm:

  1) Failure:
TestPlaintext#test_to_commonmark [/Users/kivikakk/Code/commonmarker/test/test_plaintext.rb:30]:
--- expected
+++ actual
@@ -1,7 +1,7 @@
 "Hi there!

 1.  I am a numeric list.
-2.  I continue the list.
+3.  I continue the list.

   - Suddenly, an unordered list!
   - What fun!

Here's a repro on github/cmark-gfm@c4de252:

$ printf '1. Henlo\n2. Yep.\n3. Cool?\n' | build/src/cmark-gfm -t plaintext
1.  Henlo
3.  Yep.
5.  Cool?

The same is also present in CommonMark output from cmark-gfm. I'll open a PR.

@anticomputer
Copy link
Contributor Author

We'll update (or close and replace) this PR with a series of fixes from cmark-gfm, including the list numbering issue, thanks for catching that @kivikakk

@anticomputer anticomputer marked this pull request as draft April 3, 2023 15:16
@anticomputer anticomputer changed the title Update to 0.29.0.gfm.10 Update to 0.29.0.gfm.11 Apr 3, 2023
@anticomputer anticomputer changed the title Update to 0.29.0.gfm.11 Update to 0.29.0.gfm.10 Apr 6, 2023
@anticomputer anticomputer changed the title Update to 0.29.0.gfm.10 Update to 0.29.0.gfm.11 Apr 6, 2023
@anticomputer anticomputer marked this pull request as ready for review April 6, 2023 18:45
@anticomputer anticomputer marked this pull request as draft April 6, 2023 18:49
@anticomputer anticomputer marked this pull request as ready for review April 11, 2023 17:43
Copy link
Collaborator

@phillmv phillmv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve!

@phillmv phillmv merged commit 42cfc90 into gjtorikian:c-api-stable Apr 11, 2023
4 checks passed
@anticomputer anticomputer deleted the update-to-0.29.0.gfm.10 branch April 11, 2023 18:53
wataru86 added a commit to increments/qiita_marker that referenced this pull request May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants