Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run integration test PR checks nightly #2222

Merged
merged 2 commits into from Apr 4, 2024

Conversation

angelapwen
Copy link
Contributor

Scheduled for 5AM UTC. This will assist in catching bugs introduced with new runner images.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

aeisenberg
aeisenberg previously approved these changes Apr 3, 2024
@aeisenberg
Copy link
Contributor

Oops. Still in draft. Code looks good. Let's :shipit: if everything passes.

@angelapwen
Copy link
Contributor Author

Oops. Still in draft. Code looks good. Let's :shipit: if everything passes.

I still haven't configured a notification to our team if any of these fail (see backlinked issue). I can do that in a follow-up if we want to start running immediately though.

@angelapwen angelapwen marked this pull request as ready for review April 3, 2024 19:10
@angelapwen angelapwen requested a review from a team as a code owner April 3, 2024 19:10
@angelapwen angelapwen disabled auto-merge April 3, 2024 19:46
@angelapwen
Copy link
Contributor Author

angelapwen commented Apr 3, 2024

Huh... workflow files don't seem to be working with an error message:

Invalid type for `on`

I'll look into it but nothing comes top of mind as schedule is supported (and we use it elsewhere!)

EDIT: I think I see the syntax error, will fix

@angelapwen angelapwen force-pushed the angelapwen/run-checks-nightly branch 2 times, most recently from f4013bf to 1932e6e Compare April 3, 2024 20:03
Scheduled for 5AM UTC. This will assist in catching bugs introduced with new runner images.
@angelapwen angelapwen force-pushed the angelapwen/run-checks-nightly branch from 1932e6e to 9a9987f Compare April 3, 2024 20:04
For consistency with our non-autogenerated files and GitHub documentation, we should further indent items in lists (`sequence`).
@angelapwen
Copy link
Contributor Author

PR check failures are now due to upstream (usually transient) setup-swift failures.

Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. If the failures are transient, I'll leave it up to you if you want to override the failures and merge or re-run later.

@angelapwen
Copy link
Contributor Author

I don't think we have a way to force green on this repo, and I'd rather not make all those checks non-required (and then make them required again later), so I'll wait to re-run.

@angelapwen angelapwen merged commit f421cda into main Apr 4, 2024
297 checks passed
@angelapwen angelapwen deleted the angelapwen/run-checks-nightly branch April 4, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants