Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add languages and build_mode to init success status report #2175

Merged
merged 1 commit into from Feb 29, 2024

Conversation

henrymercer
Copy link
Contributor

Fix a typo where we wouldn't pass a config to the init success status report. While we're here, defensively pass config to the other createStatusReportBase calls too.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner February 29, 2024 12:20
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough, we might need those configs one day in the other status reports 😆

@angelapwen
Copy link
Contributor

Merging in before I kick off a release!

@angelapwen angelapwen merged commit 158d078 into main Feb 29, 2024
297 checks passed
@angelapwen angelapwen deleted the henrymercer/fix-languages-init-success branch February 29, 2024 13:10
@github-actions github-actions bot mentioned this pull request Feb 29, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants