Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental build-mode input #2108

Merged
merged 7 commits into from Feb 2, 2024
Merged

Conversation

henrymercer
Copy link
Contributor

This PR introduces an experimental build-mode input to the init Action. This is currently for internal testing only.

We forward this input to codeql database init and add a test to check that the build mode is forwarded to the database as expected, and Java buildless extraction completes successfully.

This PR makes use of the config refactoring implemented in #2107.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner January 31, 2024 14:49
Base automatically changed from henrymercer/refactor-config to main January 31, 2024 18:41
aeisenberg
aeisenberg previously approved these changes Jan 31, 2024
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the action iput description can be clarified, but it's not a blocking change.

init/action.yml Show resolved Hide resolved
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆒 😄

@henrymercer henrymercer merged commit 81eb6b2 into main Feb 2, 2024
319 checks passed
@henrymercer henrymercer deleted the henrymercer/build-mode-input branch February 2, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants