Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal queries: Replace deprecated predicates #2098

Merged
merged 1 commit into from Jan 24, 2024

Conversation

henrymercer
Copy link
Contributor

These predicates will be removed as of the next CLI release. Also remove getEntrypoint() in queries/required-action-input.ql since it is unused.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner January 24, 2024 12:29
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Out of curiosity, how did you find these were about to be deprecated? I'm not seeing it in the upcoming CLI release changelog

@henrymercer
Copy link
Contributor Author

We've been getting deprecation warnings for some time in the logs, e.g. https://github.com/github/codeql-action/actions/runs/7627510974/job/20776479874. These are also visible if you open the queries in VS Code.

This links into our discussion about improving changelogs — since it's a JS language support change these changes are surfaced at https://github.com/github/codeql/blob/codeql-cli-2.16.1/javascript/ql/lib/CHANGELOG.md#087.

@henrymercer henrymercer merged commit bd67d8d into main Jan 24, 2024
317 checks passed
@henrymercer henrymercer deleted the henrymercer/update-internal-queries branch January 24, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants