Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update required checks script to handle release branches #2050

Merged
merged 2 commits into from Dec 20, 2023
Merged

update required checks script to handle release branches #2050

merged 2 commits into from Dec 20, 2023

Conversation

nickfyson
Copy link
Contributor

@nickfyson nickfyson commented Dec 20, 2023 •
edited

This PR moves the definition of OLDEST_SUPPORTED_MAJOR_VERSION to a config file, and sources it both from the action that determines release branches and the script to update required checks.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@nickfyson nickfyson mentioned this pull request Dec 20, 2023
Closed
3 tasks
@nickfyson nickfyson marked this pull request as ready for review December 20, 2023 17:23
@nickfyson nickfyson requested a review from a team as a code owner December 20, 2023 17:23
aeisenberg
aeisenberg previously approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work with the bash script.

@nickfyson nickfyson merged commit 49812ec into main Dec 20, 2023
339 checks passed
@nickfyson nickfyson deleted the nickfyson/add-releases-ini branch December 20, 2023 20:18
This was referenced Dec 22, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeisenberg aeisenberg aeisenberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nickfyson @aeisenberg