Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable sub-language file coverage during interpretation and update PR check #1944

Merged
merged 2 commits into from Oct 12, 2023
Merged

Enable sub-language file coverage during interpretation and update PR check #1944

merged 2 commits into from Oct 12, 2023

Conversation

henrymercer
Copy link
Contributor

This PR:

  • Enables sub-language file coverage information during results interpretation, when the feature flag is enabled. Previously we generated the sub-language file coverage information but we didn't export it to SARIF.
  • Updates the PR check for file coverage information to include sub-language file coverage and be independent of the feature flag.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner October 12, 2023 11:18
@henrymercer henrymercer changed the title File coverage: Enable sub-language file coverage during interpretation and update PR check Enable sub-language file coverage during interpretation and update PR check Oct 12, 2023
@henrymercer henrymercer merged commit 34f97d7 into main Oct 12, 2023
330 checks passed
@henrymercer henrymercer deleted the henrymercer/sublanguage-file-coverage-fixes branch October 12, 2023 18:01
@github-actions github-actions bot mentioned this pull request Oct 13, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelapwen angelapwen angelapwen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@henrymercer @angelapwen