Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR checks: stop setting experimental Swift var for new CLI versions #1718

Merged
merged 1 commit into from Jun 6, 2023

Conversation

angelapwen
Copy link
Contributor

Now that latest and cached are both 2.13.3, which is the version in which we GA'ed Swift, we should stop setting this experimental variable when we test these CLI versions so we can test the case where the variable is unset.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

Now that `latest` and `cached` are both 2.13.3, which is the version in which we GA'ed Swift, we should stop setting this experimental variable when we test these CLI versions so we can test the case where the variable is unset.
@angelapwen angelapwen marked this pull request as ready for review June 5, 2023 20:50
@angelapwen angelapwen requested a review from a team as a code owner June 5, 2023 20:50
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Separately, we might want to rename cached to something like ghes-default — on Dotcom with controlled switchover we will follow the feature flags rather than what's in the toolcache.

@angelapwen angelapwen merged commit cdcdbb5 into github:main Jun 6, 2023
649 checks passed
@angelapwen angelapwen deleted the remove-swift-env-var branch June 6, 2023 15:49
@github-actions github-actions bot mentioned this pull request Jun 13, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants