Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix changelog for 2.3.6 #1717

Merged
merged 1 commit into from Jun 5, 2023
Merged

Fix changelog for 2.3.6 #1717

merged 1 commit into from Jun 5, 2023

Conversation

henrymercer
Copy link
Contributor

One of the changelog entries for 2.3.6 ended up incorrectly being associated with 2.3.4 due to a bad merge conflict resolution. As a long term fix, we could store unreleased changelog entries in a separate directory and only edit CHANGELOG.md with automation.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner June 5, 2023 18:18
Copy link
Contributor

@adityasharad adityasharad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separately tracking unreleased entries is a good idea, though perhaps confusing for OSS contributors. Let's figure out how to make that work and minimise conflicts.

Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching. I'd noticed the same happening in the 2.3.5 release as well (a change from 2.3.5 was added to 2.3.3 as a result of a merge conflict resolution), but caught it in time during the release.

@henrymercer henrymercer merged commit 8b0f2cf into main Jun 5, 2023
325 checks passed
@henrymercer henrymercer deleted the henrymercer/fix-changelog branch June 5, 2023 18:44
@github-actions github-actions bot mentioned this pull request Jun 13, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants