Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused CODESCANNING_EVENT_NAME environment variable #1712

Merged
merged 4 commits into from Jun 1, 2023

Conversation

henrymercer
Copy link
Contributor

This environment variable is not used by default setup, so here we remove the Action's support for it to avoid potential confusion around what workflowEventName() would produce in default setup workflow runs.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner May 31, 2023 14:39
src/actions-util.ts Outdated Show resolved Hide resolved
@henrymercer
Copy link
Contributor Author

I'll wait until we've done the Swift release before merging this out of an abundance of caution.

@adityasharad
Copy link
Contributor

Just to be sure: this was never used in a shipped GHES version?

@henrymercer
Copy link
Contributor Author

Marco and I went through the default setup templates and we have never used this functionality.

@henrymercer henrymercer merged commit 926a489 into main Jun 1, 2023
325 checks passed
@henrymercer henrymercer deleted the henrymercer/remove-unused-env-var branch June 1, 2023 17:28
@github-actions github-actions bot mentioned this pull request Jun 13, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants