Fix a circular dependency that led a minimum version to be undefined
#1578
+56
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeisenberg
approved these changes
Mar 14, 2023
angelapwen
approved these changes
Mar 14, 2023
| @@ -94,7 +94,7 @@ export class Features implements FeatureEnablement { | |||
| gitHubVersion: util.GitHubVersion, | |||
| repositoryNwo: RepositoryNwo, | |||
| tempDir: string, | |||
| logger: Logger | |||
| private readonly logger: Logger | |||
There was a problem hiding this comment.
Why do we make this private readonly?
There was a problem hiding this comment.
This makes it a field on the Features class so we can access it within getValue.
There was a problem hiding this comment.
We could also add a logger argument to getValue, but that would cause a reasonable amount of churn, and sharing the logger makes sense.
6 tasks
This was referenced Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A circular dependency between
codeql.tsandfeature-flags.tsmeant thatfeatureConfig[Feature.ExportCodeScanningConfigEnabled].minimumVersionwas undefined. This in turn meant that we tried to pass some CLI options even if we were running with an early version of the CLI where these options didn't exist.The fact that we didn't catch this in PR checks highlights the need for more comprehensive testing across the full range of minor versions we support.
Merge / deployment checklist