Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export configuration information to SARIF #1565

Merged
merged 8 commits into from Mar 13, 2023

Conversation

henrymercer
Copy link
Contributor

@henrymercer henrymercer commented Mar 7, 2023

This PR exports a configuration information summary to SARIF for green and red runs. This summary comes from the code scanning config file generated by the CLI. When the config is parsed in the Action, nothing will be exported.

We add an integration test exercising the functionality, and gate it behind a feature flag so it is easy to disable if it doesn't behave as expected in the wild.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer force-pushed the henrymercer/diagnostics-code-scanning-config branch from 9474efa to 4b1f530 Compare March 7, 2023 21:22
@henrymercer henrymercer marked this pull request as ready for review March 9, 2023 18:44
@henrymercer henrymercer requested a review from a team as a code owner March 9, 2023 18:44
angelapwen
angelapwen previously approved these changes Mar 10, 2023
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

src/feature-flags.ts Show resolved Hide resolved
pr-checks/checks/config-export.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@henrymercer henrymercer merged commit ec29823 into main Mar 13, 2023
281 checks passed
@henrymercer henrymercer deleted the henrymercer/diagnostics-code-scanning-config branch March 13, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants