Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please consider remove github.com/bytedance/sonic from dependencies #3932

Closed
hailinzhg opened this issue Apr 24, 2024 · 4 comments
Closed

Please consider remove github.com/bytedance/sonic from dependencies #3932

hailinzhg opened this issue Apr 24, 2024 · 4 comments

Comments

@hailinzhg
Copy link

  • With issues:
    • Use the search tool before opening a new issue.
    • Please provide source code and commit sha if you found a bug.
    • Review existing issues and provide feedback or react to them.

Description

module github.com/bytedance/sonic is not well maintained and it's sum changes violently.
image

Environment

  • go version: v1.21.9
  • gin version (or commit ref): v1.9.0
  • operating system:
@hailinzhg hailinzhg changed the title Please consider remove bytedance/sonic from dependencies Please consider remove github.com/bytedance/sonic from dependencies Apr 24, 2024
@hailinzhg
Copy link
Author

bytedance/sonic#622

@AsterDY
Copy link

AsterDY commented Apr 24, 2024

Sorry for disturbing you. We pushed a new version (sonic v1.11.6 ) to resolve this problem

@hailinzhg
Copy link
Author

Sorry for disturbing you. We pushed a new version (sonic v1.11.6 ) to resolve this problem

Thanks for your reply.

@hailinzhg
Copy link
Author

Gin is a good framework and I'm grateful for all the contributors. But now it seems it's carrying too much dependencies that someone may not need. Wish the pluggable functions moved to separate go modules so that users can plug in when need, that will greatly help a go project's simplicity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants