Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add s390x cpu support to install.js and CI #412

Merged
merged 2 commits into from Jun 1, 2023

Conversation

kun-lu20
Copy link
Contributor

@kun-lu20 kun-lu20 commented May 11, 2023

Currently node-chromedriver only supports Intel and ARM cpu. This PR aims to add s390x support to this repo and the CI pipeline.

Signed-off-by: Kun-Lu <kun.lu@ibm.com>
Signed-off-by: Kun-Lu <kun.lu@ibm.com>
@giggio
Copy link
Owner

giggio commented May 11, 2023

This is cool, I'm on vacation now, I'll check it out as soon as I get some time, it'll be soon.

@kun-lu20
Copy link
Contributor Author

Thanks @giggio !

@stale stale bot added the wontfix label May 21, 2023
Repository owner deleted a comment from stale bot May 21, 2023
@giggio giggio merged commit c123b59 into giggio:main Jun 1, 2023
22 checks passed
@giggio
Copy link
Owner

giggio commented Jun 1, 2023

I'll release 114.0.1 in a minute. Thanks, @kun-lu20 !

@kun-lu20
Copy link
Contributor Author

kun-lu20 commented Jun 1, 2023

Thank you so much @giggio !

@github-actions
Copy link

github-actions bot commented Jun 9, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants