Skip to content

ci : increase windows-cublas evict-old-files to 5d #2915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

danbev
Copy link
Collaborator

@danbev danbev commented Mar 21, 2025

This commit updates the evict-old-files parameter for the windows-cublas build job to 5 days.

The motivation for this change is to avoid the full rebuild which takes around 1.5 hours for the windows-cublas build job. Considering that there are periods of low traffic on whisper.cpp (like weekends etc.) it might be better to have a longer eviction policy to avoid the full rebuild.

This commit updates the evict-old-files parameter for the windows-cublas
build job to 5 days.

The motivation for this change is to avoid the full rebuild which takes
around 1.5 hours for the windows-cublas build job. Considering that
there are periods of low traffic on whisper.cpp (like weekends etc.) it
might be better to have a longer eviction policy to avoid the full
rebuild.
@danbev danbev merged commit 4e56747 into ggml-org:master Mar 21, 2025
47 checks passed
@slaren
Copy link
Member

slaren commented Mar 21, 2025

I suspect that the reason it takes so long is due to the -DCMAKE_CUDA_ARCHITECTURES=all in
https://github.com/danbev/whisper.cpp/blob/54f6043fff05e4f455c5934859e861029a79c4ab/.github/workflows/build.yml#L831C1-L831C46
I would suggest removing that and building for the default architectures only, there is little benefit from building for all architectures.

@danbev
Copy link
Collaborator Author

danbev commented Mar 22, 2025

I would suggest removing that and building for the default architectures only, there is little benefit from building for all architectures.

Nice, I'll give that a try, thanks!

danbev added a commit to danbev/whisper.cpp that referenced this pull request Mar 22, 2025
This commit removes the -DCMAKE_CUDA_ARCHITECTURES=all flag from the
windows-cublas job in the build.yml file.

The motivation for this is that building for all architectures is
unnecessary and takes a long time. Without this flag the architectures
will instead be set by ggml-cuda.

Refs: ggml-org#2915 (comment)
danbev added a commit that referenced this pull request Mar 22, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
This commit removes the -DCMAKE_CUDA_ARCHITECTURES=all flag from the
windows-cublas job in the build.yml file.

The motivation for this is that building for all architectures is
unnecessary and takes a long time. Without this flag the architectures
will instead be set by ggml-cuda.

Refs: #2915 (comment)
buxuku pushed a commit to buxuku/whisper.cpp that referenced this pull request Mar 26, 2025
This commit updates the evict-old-files parameter for the windows-cublas
build job to 5 days.

The motivation for this change is to avoid the full rebuild which takes
around 1.5 hours for the windows-cublas build job. Considering that
there are periods of low traffic on whisper.cpp (like weekends etc.) it
might be better to have a longer eviction policy to avoid the full
rebuild.
buxuku pushed a commit to buxuku/whisper.cpp that referenced this pull request Mar 26, 2025
This commit removes the -DCMAKE_CUDA_ARCHITECTURES=all flag from the
windows-cublas job in the build.yml file.

The motivation for this is that building for all architectures is
unnecessary and takes a long time. Without this flag the architectures
will instead be set by ggml-cuda.

Refs: ggml-org#2915 (comment)
@danbev danbev deleted the ci-windows-cublas-evict-update branch April 1, 2025 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants