[Fix] When m_audio_pos overflows, m_audio_len should also increase in… #2855
+2
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… length instead of setting it directly to the buffer length.
ggerganov
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In audio_sync, m_audio_pos records the position that should be written from the SDL buffer callback, and m_audio_len records the length of the buffer that has been written.
When the m_audio buffer overflows, m_audio_len is directly set to the buffer length. Is it more reasonable to change this behavior to increase with m_audio_pos until the maximum value? Although this change cannot be realized when the audio stream is read-only or cleared, it seems to be more in line with its meaning?