Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge RWKV back to GGML? #266

Closed
m1chae1bx opened this issue Jun 17, 2023 · 4 comments
Closed

Merge RWKV back to GGML? #266

m1chae1bx opened this issue Jun 17, 2023 · 4 comments

Comments

@m1chae1bx
Copy link

https://github.com/saharNooby/rwkv.cpp is a forked GGML version that implements the RNN-Transformer model RWKV.

@saharNooby
Copy link

Hi! Can you elaborate on what value it will bring to merge the rwkv.cpp repo into ggml?

As I see it myself: ggml is fundametnally a library/framework, and merging downstream application into it is like merging transformers into PyTorch, or merging stable-diffusion-webui into gradio.

Furthermore, maybe ggml can be extended with a simple example of RWKV inference; but rwkv.cpp has outgrown its "prototype & example" phase, and we have plans about extending it even more. I think being in ggml repo will constrain rwkv.cpp development heavily.

@m1chae1bx
Copy link
Author

Apologies. I used the wrong word. Merge is not really what I meant but as what you have said, implement a sample inference based on rwkv.cpp. It’ll be beneficial to downstream libraries built on top of GGML like ctransformers.

@ggerganov
Copy link
Owner

The rkwv.cpp project is doing a great job at maintaining and supporting, so there is no great value in adding the code back to this repo. The only potential benefit from having a minimalistic rwkv example here is that in the future, when we update ggml we can easily adapt the example to the new changes and then the rwkv.cpp will have an easier time into upgrading to the new ggml version. But again, I think it's fine the way it is

@m1chae1bx
Copy link
Author

Okay, noted.

@m1chae1bx m1chae1bx closed this as not planned Won't fix, can't repro, duplicate, stale Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants