Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wgpu_hal::Surface::discard_texture broken on Vulkan #5723

Open
jimblandy opened this issue May 20, 2024 · 0 comments
Open

wgpu_hal::Surface::discard_texture broken on Vulkan #5723

jimblandy opened this issue May 20, 2024 · 0 comments
Labels
api: vulkan Issues with Vulkan type: bug Something isn't working

Comments

@jimblandy
Copy link
Member

The implementation of wgpu_hal::Surface::discard_texture in the vulkan backend does nothing. If it is ever called, presumably some subsequent call to acquire_texture will hang, since the texture will never be re-used.

Since wgpu_hal only permits the acquisition of a single surface texture at a time, it should be sufficient for the discard_texture implementation to simply save the texture away somewhere and hand it out again from the next acquire_texture call.

This issue was noticed in the review for #5681.

@Wumpf Wumpf added type: bug Something isn't working api: vulkan Issues with Vulkan labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: vulkan Issues with Vulkan type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants