Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wgsl-out] Align and size attributes not being output #4373

Open
teoxoy opened this issue Apr 7, 2022 · 1 comment · May be fixed by gfx-rs/naga#2450
Open

[wgsl-out] Align and size attributes not being output #4373

teoxoy opened this issue Apr 7, 2022 · 1 comment · May be fixed by gfx-rs/naga#2450
Labels
area: naga back-end Outputs of naga shader conversion help wanted Contributions encouraged kind: feature New feature or request lang: WGSL WebGPU Shading Language naga Shader Translator

Comments

@teoxoy
Copy link
Member

teoxoy commented Apr 7, 2022 •
edited

Tested by passing a WGSL shader trough naga.

I think we'll need at least struct member alignment in the IR for this to work.
@kvark kvark added kind: feature New feature or request help wanted Contributions encouraged lang: WGSL WebGPU Shading Language area: naga back-end Outputs of naga shader conversion labels Apr 11, 2022
@mikialex
Copy link

Has anyone worked on this issue?

We building the naga shader module directly in runtime by our material system. Missing correct alignment and size output is a blocking issue for us because we have to output wgsl on web platform.

@mikialex mikialex linked a pull request Aug 21, 2023 that will close this issue
Open
@cwfitzgerald cwfitzgerald transferred this issue from gfx-rs/naga Oct 25, 2023
@cwfitzgerald cwfitzgerald added the naga Shader Translator label Oct 25, 2023
@kvark kvark mentioned this issue Nov 13, 2021
Open
@robtfm robtfm mentioned this issue Feb 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: naga back-end Outputs of naga shader conversion help wanted Contributions encouraged kind: feature New feature or request lang: WGSL WebGPU Shading Language naga Shader Translator
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix wgsl out struct layout mikialex/naga
4 participants
@kvark @cwfitzgerald @mikialex @teoxoy