Make regex an optional dependency #659
Merged
+15
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest release includes
regex
and family—I'd very much like to avoid those if possible, since they are big chunky crates with slow compile times.For now, the easiest thing seems to be to gate the inclusion of
regex
onUNSTABLE_metrics
since it is only used in that code path.Longer-term, I'd appreciate either reverting to the pre- #658 implementation that looks something like
c.is_ascii_alphanumeric() || matches!(c, '_' | '-' | '.' | '/')
(since it's a relatively simple regex) or looking into a lighter crate like regex-lite.