Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure enabled_environments is respected everywhere #2287

Closed
sl0thentr0py opened this issue Apr 2, 2024 · 0 comments · Fixed by #2291
Closed

Make sure enabled_environments is respected everywhere #2287

sl0thentr0py opened this issue Apr 2, 2024 · 0 comments · Fixed by #2291
Assignees
@sl0thentr0py
Labels
metrics Type: Bug

Comments

@sl0thentr0py
Copy link
Member

sl0thentr0py commented Apr 2, 2024 •
edited

for metrics/client reports/sessions we enqueue envelopes directly, make sure we check enabled_environments for all such cases.
@sl0thentr0py sl0thentr0py self-assigned this Apr 2, 2024
@matejminar matejminar mentioned this issue Apr 8, 2024
Closed
sl0thentr0py added a commit that referenced this issue Apr 8, 2024
@sl0thentr0py
Make sure isolated envelopes respect enabled_environments
7bbbb4c 
Envelopes for metrics/sessions and so on were queued directly before and
thus did not respect the config. This introduces a dedicated
`capture_envelope` on the client to centralize these checks.

Closes #2287
@sl0thentr0py sl0thentr0py mentioned this issue Apr 8, 2024
Merged
sl0thentr0py added a commit that referenced this issue Apr 8, 2024
@sl0thentr0py
Make sure isolated envelopes respect enabled_environments
9ab0fd4 
Envelopes for metrics/sessions and so on were queued directly before and
thus did not respect the config. This introduces a dedicated
`capture_envelope` on the client to centralize these checks.

Closes #2287
sl0thentr0py added a commit that referenced this issue Apr 9, 2024
@sl0thentr0py
Make sure isolated envelopes respect enabled_environments
c353dcc 
Envelopes for metrics/sessions and so on were queued directly before and
thus did not respect the config. This introduces a dedicated
`capture_envelope` on the client to centralize these checks.

Closes #2287
sl0thentr0py added a commit that referenced this issue Apr 9, 2024
@sl0thentr0py
Make sure isolated envelopes respect enabled_environments (#2291)
aa2e2e6 
Envelopes for metrics/sessions and so on were queued directly before and
thus did not respect the config. This introduces a dedicated
`capture_envelope` on the client to centralize these checks.

Closes #2287
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sl0thentr0py sl0thentr0py

Labels
metrics Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make sure isolated envelopes respect enabled_environments getsentry/sentry-ruby
2 participants
@sl0thentr0py @stephanie-anderson