Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify what is creating a background worker #2256

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

llhhaa
Copy link
Contributor

@llhhaa llhhaa commented Mar 6, 2024

Description

Describe your changes:

When running Rails tasks, I see something "initializing the background worker", e.g.:

> bin/rails c
Initializing the background worker with 5 threads
Loading development environment (Rails 7.0.8.1)
[1] pry(main)>

I thought it might be helpful if this message indicated what it is - Sentry - that is doing this:

> bin/rails c
Initializing the Sentry background worker with 5 threads
Loading development environment (Rails 7.0.8.1)
[1] pry(main)>

#skip-changelog

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Merging #2256 (23de453) into master (478c4cf) will increase coverage by 0.20%.
Report is 4 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2256      +/-   ##
==========================================
+ Coverage   97.41%   97.61%   +0.20%     
==========================================
  Files         102      112      +10     
  Lines        3828     4153     +325     
==========================================
+ Hits         3729     4054     +325     
  Misses         99       99              
Components Coverage Δ
sentry-ruby 98.30% <100.00%> (+0.16%) ⬆️
sentry-rails 95.05% <ø> (ø)
sentry-sidekiq 94.70% <ø> (ø)
sentry-resque 92.30% <ø> (+1.53%) ⬆️
sentry-delayed_job 95.60% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)
Files Coverage Δ
sentry-ruby/lib/sentry/background_worker.rb 100.00% <100.00%> (ø)

... and 20 files with indirect coverage changes

@sl0thentr0py sl0thentr0py merged commit 213e2ab into getsentry:master Mar 13, 2024
123 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants