Skip to content

fix(ai): Do not consume anthropic streaming stop #4232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

colin-sentry
Copy link
Member

The old functionality wouldn't re-emit the stop message for streaming Anthropic calls.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@colin-sentry colin-sentry requested a review from a team as a code owner April 2, 2025 12:55
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.49%. Comparing base (8b40aa0) to head (8efee7d).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4232      +/-   ##
==========================================
- Coverage   79.52%   79.49%   -0.03%     
==========================================
  Files         141      141              
  Lines       15810    15808       -2     
  Branches     2704     2702       -2     
==========================================
- Hits        12573    12567       -6     
- Misses       2378     2382       +4     
  Partials      859      859              
Files with missing lines Coverage Δ
sentry_sdk/integrations/anthropic.py 85.29% <100.00%> (+0.99%) ⬆️

... and 4 files with indirect coverage changes

Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@antonpirker antonpirker merged commit e4b8dae into master Apr 2, 2025
139 checks passed
@antonpirker antonpirker deleted the stop_messages_removed branch April 2, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Anthropic integration unexpectedly drops message_stop events from streamed responses
2 participants