Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Move mypy config into pyproject.toml #4181

Merged
merged 3 commits into from
Mar 21, 2025

Conversation

antonpirker
Copy link
Member

@antonpirker antonpirker commented Mar 21, 2025

First step to consolidate configuration into pyproject.toml.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.56%. Comparing base (c295047) to head (5d409b0).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4181      +/-   ##
==========================================
- Coverage   79.58%   79.56%   -0.02%     
==========================================
  Files         141      141              
  Lines       15736    15736              
  Branches     2675     2675              
==========================================
- Hits        12524    12521       -3     
- Misses       2367     2369       +2     
- Partials      845      846       +1     

see 2 files with indirect coverage changes

@antonpirker antonpirker changed the title Move mypy config into pyproject.toml ci: Move mypy config into pyproject.toml Mar 21, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…t-toml
@antonpirker antonpirker requested a review from a team as a code owner March 21, 2025 09:48
Copy link
Member

@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments before merge. Also, if there is an issue associated with this PR, might help to link them for context (I was kinda missing context when reviewing this)

disallow_untyped_defs = true
no_implicit_optional = true
python_version = "3.11"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of scope for this PR, but perhaps we should bump this?

Co-authored-by: Daniel Szoke <7881302+szokeasaurusrex@users.noreply.github.com>
@antonpirker antonpirker enabled auto-merge (squash) March 21, 2025 09:59
@antonpirker antonpirker merged commit 8ad0d01 into master Mar 21, 2025
139 checks passed
@antonpirker antonpirker deleted the antonpirker/move-mypy-config-into-pyproject-toml branch March 21, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants