Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(profiler): Add deprecation warning for session functions #4171

Merged
merged 1 commit into from
Mar 20, 2025

Conversation

sentrivana
Copy link
Contributor

We're deprecating the short-lived start_profile_session and stop_profile_session functions in favor of start_profiler and stop_profiler, respectively.

The functions will be dropped in 3.x, see #4170

Verified

This commit was signed with the committer’s verified signature.
qwerzl Tom Tang
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.56%. Comparing base (f6db981) to head (56c4324).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4171      +/-   ##
==========================================
+ Coverage   79.49%   79.56%   +0.06%     
==========================================
  Files         141      141              
  Lines       15732    15735       +3     
  Branches     2675     2675              
==========================================
+ Hits        12506    12519      +13     
+ Misses       2379     2369      -10     
  Partials      847      847              
Files with missing lines Coverage Δ
sentry_sdk/profiler/continuous_profiler.py 86.03% <100.00%> (+0.45%) ⬆️

... and 5 files with indirect coverage changes

@sentrivana sentrivana merged commit eb189ef into master Mar 20, 2025
140 checks passed
@sentrivana sentrivana deleted the ivana/deprecate-profile-session-funcs branch March 20, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants