Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed flaky test #4165

Merged
merged 4 commits into from
Mar 20, 2025
Merged

Fixed flaky test #4165

merged 4 commits into from
Mar 20, 2025

Conversation

antonpirker
Copy link
Member

The URL www.squirrelchasers.com is actually existing, so we should not access it in our tests. Hope this make the test more stable.

Verified

This commit was signed with the committer’s verified signature.
Josh-Cena Joshua Chen
@antonpirker antonpirker requested a review from sentrivana March 19, 2025 11:10
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.57%. Comparing base (f6db981) to head (7fb4b42).
Report is 2 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4165      +/-   ##
==========================================
+ Coverage   79.49%   79.57%   +0.07%     
==========================================
  Files         141      141              
  Lines       15732    15732              
  Branches     2675     2675              
==========================================
+ Hits        12506    12518      +12     
+ Misses       2379     2368      -11     
+ Partials      847      846       -1     

see 5 files with indirect coverage changes

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@antonpirker antonpirker marked this pull request as ready for review March 19, 2025 11:22
Copy link
Member

@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't a more robust solution be to use a mock server? I feel like tests in general should not be depending on a real network connection, as it introduces to many opportunities for flakiness

Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

@antonpirker antonpirker enabled auto-merge (squash) March 20, 2025 08:12
@antonpirker antonpirker merged commit f76528f into master Mar 20, 2025
140 checks passed
@antonpirker antonpirker deleted the antonpirker/fix-test branch March 20, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants