-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset DedupeIntegration
's last-seen
if before_send
dropped the event
#4142
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #4142 +/- ##
==========================================
- Coverage 79.58% 79.55% -0.03%
==========================================
Files 141 141
Lines 15723 15732 +9
Branches 2673 2675 +2
==========================================
+ Hits 12513 12516 +3
- Misses 2367 2370 +3
- Partials 843 846 +3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess there code be an edge case that causes problem. (see my comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Imagine an app throws an exception twice, from different places. The first exception is dropped in the user's
before_send
. The second exception is not. Should the second exception appear in Sentry?The current state is that it won't, since
DedupeIntegration
will take the first, dropped exception into account. When encountering the second exception, it'll consider it a duplicate and will drop it, even though the first exception never made it to Sentry.In this PR, we reset
DedupeIntegration
'slast-seen
if an event has been dropped bybefore_send
, ensuring that the next exception will be reported.Closes #371