Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bottle): Prevent internal error on 404 #4131

Merged
merged 2 commits into from
Mar 13, 2025

Conversation

sentrivana
Copy link
Contributor

request.route can throw a RuntimeError: This request is not connected to a route..

Closes #3583

@sentrivana sentrivana marked this pull request as ready for review March 12, 2025 16:01
@sentrivana sentrivana requested a review from antonpirker March 12, 2025 16:01
@sentrivana sentrivana enabled auto-merge (squash) March 12, 2025 16:03
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@sentrivana sentrivana merged commit 78db2ec into master Mar 13, 2025
139 of 140 checks passed
@sentrivana sentrivana deleted the ivana/bottle-no-internal-error branch March 13, 2025 15:12
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 79.43%. Comparing base (4c9731b) to head (38c304b).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sentry_sdk/integrations/bottle.py 50.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4131      +/-   ##
==========================================
- Coverage   79.48%   79.43%   -0.06%     
==========================================
  Files         140      140              
  Lines       15624    15630       +6     
  Branches     2651     2651              
==========================================
- Hits        12419    12415       -4     
- Misses       2372     2376       +4     
- Partials      833      839       +6     
Files with missing lines Coverage Δ
sentry_sdk/integrations/bottle.py 82.14% <50.00%> (-2.77%) ⬇️

... and 8 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bottle 404 causes internal error
2 participants