Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pyspark): Grab attemptId more defensively #4130

Merged
merged 8 commits into from
Mar 12, 2025
Merged

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Mar 12, 2025

Closes #1099

Verified

This commit was signed with the committer’s verified signature.
sentrivana Ivana Kellyer

Verified

This commit was signed with the committer’s verified signature.
sentrivana Ivana Kellyer
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.62%. Comparing base (a97c53c) to head (7e0e2e2).
Report is 3 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sentry_sdk/integrations/spark/spark_driver.py 94.44% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4130      +/-   ##
==========================================
+ Coverage   79.53%   79.62%   +0.08%     
==========================================
  Files         140      140              
  Lines       15594    15610      +16     
  Branches     2647     2649       +2     
==========================================
+ Hits        12403    12429      +26     
+ Misses       2351     2342       -9     
+ Partials      840      839       -1     
Files with missing lines Coverage Δ
sentry_sdk/integrations/spark/spark_driver.py 64.11% <94.44%> (+3.07%) ⬆️

... and 5 files with indirect coverage changes

.

Verified

This commit was signed with the committer’s verified signature.
sentrivana Ivana Kellyer

Verified

This commit was signed with the committer’s verified signature.
sentrivana Ivana Kellyer

Verified

This commit was signed with the committer’s verified signature.
sentrivana Ivana Kellyer

Verified

This commit was signed with the committer’s verified signature.
sentrivana Ivana Kellyer

Verified

This commit was signed with the committer’s verified signature.
sentrivana Ivana Kellyer
.

Verified

This commit was signed with the committer’s verified signature.
sentrivana Ivana Kellyer
@sentrivana sentrivana marked this pull request as ready for review March 12, 2025 13:42
@sentrivana sentrivana requested a review from antonpirker March 12, 2025 13:42
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@sentrivana sentrivana merged commit e8be8ed into master Mar 12, 2025
142 checks passed
@sentrivana sentrivana deleted the ivana/pyspark-fix branch March 12, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pyspark Driver Integration errors out with py4j.Py4JException: Method attemptId([]) does not exist
2 participants