Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coerce None values into strings in logentry params. #4121

Merged
merged 7 commits into from
Mar 12, 2025

Conversation

antonpirker
Copy link
Member

Nice rendering of log messages containing parameters that are None values does not work. There we coerce None values into strings to have nicer messages in Sentry UI.

Fixes #3660

Verified

This commit was signed with the committer’s verified signature.
jrfnl Juliette
@antonpirker antonpirker self-assigned this Mar 6, 2025
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.56%. Comparing base (42ad8df) to head (909d94c).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4121      +/-   ##
==========================================
+ Coverage   79.49%   79.56%   +0.07%     
==========================================
  Files         140      140              
  Lines       15624    15624              
  Branches     2650     2651       +1     
==========================================
+ Hits        12420    12431      +11     
+ Misses       2369     2360       -9     
+ Partials      835      833       -2     
Files with missing lines Coverage Δ
sentry_sdk/integrations/logging.py 89.10% <ø> (ø)

... and 5 files with indirect coverage changes

Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

Some tests also need updating, it seems. It'd also be great to have a test case for the None case specifically.

@antonpirker antonpirker enabled auto-merge (squash) March 12, 2025 14:44
@antonpirker antonpirker merged commit 4c9731b into master Mar 12, 2025
140 checks passed
@antonpirker antonpirker deleted the antonpirker/fix/logging-params-as-strings branch March 12, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logging message is unrendered on a webhook call
2 participants