Don't set transaction status to error on sys.exit(0) #4025
Merged
+67
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We set transaction status to
internal_error
if there is an exception exiting thestart_transaction
context manager. We don't check what kind of exception it was.Some exceptions aren't a sign of anything wrong, like
SystemExit
with a value of 0, so we shouldn't mark the transaction as failed in that case.Closes #4024