-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(flags): add Statsig integration #4022
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #4022 +/- ##
==========================================
- Coverage 80.26% 80.26% -0.01%
==========================================
Files 139 140 +1
Lines 15417 15442 +25
Branches 2606 2608 +2
==========================================
+ Hits 12374 12394 +20
- Misses 2203 2207 +4
- Partials 840 841 +1
|
May need some help debugging the failed CI.. it's warning about unknown config options found in pytest.ini: asyncio_mode and asyncio_default_fixture_loop_scope |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Folks, this looks good to me. I fixed up the test setup a bit and added a minimum version check to the integration (set to 0.55.3). Feel free to merge if the changes look good to you.
We will also need integration docs for this -- anyone on it already? Otherwise I'll whip something up |
I was planning to whip one up tomorrow or friday! |
New integration for tracking Statsig (pypi) flag evaluations, specifically the checkGate method which is used for boolean release flags. Unlike JS, there's no support for event callbacks for Statsig's server SDKs. Instead we wrap the module-level
check_gate
function.Ref https://develop.sentry.dev/sdk/expected-features/#feature-flags
Ref