Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mypy #4019

Merged
merged 4 commits into from
Feb 6, 2025
Merged

Fix mypy #4019

merged 4 commits into from
Feb 6, 2025

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Feb 6, 2025

mypy is unhappy in CI, fix it.

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.23%. Comparing base (797e82f) to head (2bc46ae).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sentry_sdk/integrations/tornado.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4019   +/-   ##
=======================================
  Coverage   80.22%   80.23%           
=======================================
  Files         139      139           
  Lines       15399    15403    +4     
  Branches     2601     2601           
=======================================
+ Hits        12354    12358    +4     
  Misses       2203     2203           
  Partials      842      842           
Files with missing lines Coverage Δ
sentry_sdk/integrations/grpc/__init__.py 91.89% <100.00%> (ø)
sentry_sdk/integrations/socket.py 94.00% <100.00%> (+0.52%) ⬆️
sentry_sdk/integrations/tornado.py 80.53% <0.00%> (ø)

@sentrivana sentrivana changed the title Test CI Fix mypy Feb 6, 2025
@sentrivana sentrivana marked this pull request as ready for review February 6, 2025 12:25
@sentrivana sentrivana enabled auto-merge (squash) February 6, 2025 12:29
@sentrivana sentrivana merged commit 1fd2b86 into master Feb 6, 2025
149 checks passed
@sentrivana sentrivana deleted the ivana/fix-mypy branch February 6, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants