Update sample rate in DSC #4018
Merged
+127
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
sentrivana
commented
Feb 6, 2025
Comment on lines
+1048
to
+1056
| propagation_context = self.get_active_propagation_context() | ||
| if propagation_context: | ||
| dsc = propagation_context.dynamic_sampling_context | ||
| if dsc is not None: | ||
| dsc["sample_rate"] = str(transaction.sample_rate) | ||
| if transaction._baggage: | ||
| transaction._baggage.sentry_items["sample_rate"] = str( | ||
| transaction.sample_rate | ||
| ) |
There was a problem hiding this comment.
For some reason, the baggage on the transaction is independent from the propagation context? In any case, I'm changing both here...
There was a problem hiding this comment.
I think that's ok. transaction._baggage is for the current transaction and on the scope it is for future transactions. So looks correct.
antonpirker
approved these changes
Feb 10, 2025
Comment on lines
+1048
to
+1056
| propagation_context = self.get_active_propagation_context() | ||
| if propagation_context: | ||
| dsc = propagation_context.dynamic_sampling_context | ||
| if dsc is not None: | ||
| dsc["sample_rate"] = str(transaction.sample_rate) | ||
| if transaction._baggage: | ||
| transaction._baggage.sentry_items["sample_rate"] = str( | ||
| transaction.sample_rate | ||
| ) |
There was a problem hiding this comment.
I think that's ok. transaction._baggage is for the current transaction and on the scope it is for future transactions. So looks correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sample_ratein DSC after the initial sampling decision is madePart of #3999