-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run AWS Lambda tests locally #3988
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #3988 +/- ##
==========================================
+ Coverage 79.53% 79.55% +0.01%
==========================================
Files 140 140
Lines 15594 15594
Branches 2647 2647
==========================================
+ Hits 12403 12406 +3
- Misses 2351 2355 +4
+ Partials 840 833 -7 |
ffe9693
to
d12abf5
Compare
2cde31a
to
a89b3c4
Compare
Because we changed our AWS Lambda test suite to not create real Lambda functions but rather run a Lambda environment locally, we do not need all the code necessary for handling the authentication to AWS in the test suite. This PR removes all the AWS auth related code and als moves the AWS Lambda testsuite again into the "Cloud" group of test suites, because it is a "normal" test suite again. The PR that includes the change to have a local Lambda environment is here: #3988
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looking great. I tried comparing the old tests to the new ones and it seems to me like we might not be testing the following anymore:
- sampling context being correct (old test name was
test_traces_sampler_gets_correct_values_in_sampling_context
) - different behavior if perf is enabled/disabled (tests ending in
..._performance_enabled/disabled
)
Maybe this is included in the new tests, it's just hard to diff 😇
df14176
to
2e75f79
Compare
Test Sentry AWS Lambda integration locally instead of creating actual Lambda function in AWS:
There is also a follow-up PR that removes obsolete code handling AWS authentication data: #4076 (This PR will also fix the one failing test)
Fixes #2795