Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): Check that __module__ is str #3942

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

szokeasaurusrex
Copy link
Member

Fixes #3939

Verified

This commit was signed with the committer’s verified signature.
ocelotl Diego Hurtado
Fixes #3939
Copy link

codecov bot commented Jan 17, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
13859 1 13858 4175
View the top 1 failed tests by shortest run time
tests.integrations.httpx.test_httpx test_omit_url_data_if_parsing_fails
Stack Traces | 13.2s run time
.tox/py3.11-httpx-v0.25/lib/python3.11.../httpx/_transports/default.py:66: in map_httpcore_exceptions
    yield
.tox/py3.11-httpx-v0.25/lib/python3.11.../httpx/_transports/default.py:228: in handle_request
    resp = self._pool.handle_request(req)
.tox/py3.11-httpx-v0.25/lib/python3.11.../httpcore/_sync/connection_pool.py:256: in handle_request
    raise exc from None
.tox/py3.11-httpx-v0.25/lib/python3.11.../httpcore/_sync/connection_pool.py:236: in handle_request
    response = connection.handle_request(
.tox/py3.11-httpx-v0.25/lib/python3.11.../httpcore/_sync/connection.py:103: in handle_request
    return self._connection.handle_request(request)
.tox/py3.11-httpx-v0.25/lib/python3.11.../httpcore/_sync/http11.py:136: in handle_request
    raise exc
.tox/py3.11-httpx-v0.25/lib/python3.11.../httpcore/_sync/http11.py:106: in handle_request
    ) = self._receive_response_headers(**kwargs)
.tox/py3.11-httpx-v0.25/lib/python3.11.../httpcore/_sync/http11.py:177: in _receive_response_headers
    event = self._receive_event(timeout=timeout)
.tox/py3.11-httpx-v0.25/lib/python3.11.../httpcore/_sync/http11.py:217: in _receive_event
    data = self._network_stream.read(
.tox/py3.11-httpx-v0.25/lib/python3.11.../httpcore/_backends/sync.py:126: in read
    with map_exceptions(exc_map):
.../hostedtoolcache/Python/3.11.11....../x64/lib/python3.11/contextlib.py:158: in __exit__
    self.gen.throw(typ, value, traceback)
.tox/py3.11-httpx-v0.25/lib/python3.11.../site-packages/httpcore/_exceptions.py:14: in map_exceptions
    raise to_exc(exc) from exc
E   httpcore.ReadTimeout: timed out

The above exception was the direct cause of the following exception:
.../integrations/httpx/test_httpx.py:305: in test_omit_url_data_if_parsing_fails
    response = httpx_client.get(url)
.tox/py3.11-httpx-v0.25/lib/python3.11................../site-packages/httpx/_client.py:1041: in get
    return self.request(
.tox/py3.11-httpx-v0.25/lib/python3.11................../site-packages/httpx/_client.py:814: in request
    return self.send(request, auth=auth, follow_redirects=follow_redirects)
sentry_sdk/utils.py:1862: in runner
    return sentry_patched_function(*args, **kwargs)
sentry_sdk/integrations/httpx.py:86: in send
    rv = real_send(self, request, **kwargs)
.tox/py3.11-httpx-v0.25/lib/python3.11................../site-packages/httpx/_client.py:901: in send
    response = self._send_handling_auth(
.tox/py3.11-httpx-v0.25/lib/python3.11................../site-packages/httpx/_client.py:929: in _send_handling_auth
    response = self._send_handling_redirects(
.tox/py3.11-httpx-v0.25/lib/python3.11................../site-packages/httpx/_client.py:966: in _send_handling_redirects
    response = self._send_single_request(request)
.tox/py3.11-httpx-v0.25/lib/python3.11................../site-packages/httpx/_client.py:1002: in _send_single_request
    response = transport.handle_request(request)
.tox/py3.11-httpx-v0.25/lib/python3.11.../httpx/_transports/default.py:227: in handle_request
    with map_httpcore_exceptions():
.../hostedtoolcache/Python/3.11.11....../x64/lib/python3.11/contextlib.py:158: in __exit__
    self.gen.throw(typ, value, traceback)
.tox/py3.11-httpx-v0.25/lib/python3.11.../httpx/_transports/default.py:83: in map_httpcore_exceptions
    raise mapped_exc(message) from exc
E   httpx.ReadTimeout: timed out

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@szokeasaurusrex szokeasaurusrex merged commit a85f0fb into master Jan 20, 2025
145 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/module_str branch January 20, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decorator @sentry_sdk.trace is not compatible with Click (edge case)
2 participants