Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(Arq): fix integration with Worker settings as a dict #3742

Merged
merged 4 commits into from
Nov 6, 2024
Merged

Fix(Arq): fix integration with Worker settings as a dict #3742

merged 4 commits into from
Nov 6, 2024
+110 −14

Conversation

saber-solooki
Copy link
Contributor

Fix #3741

@saber-solooki saber-solooki mentioned this pull request Nov 5, 2024
Closed
@saber-solooki saber-solooki changed the title Fix(Arq): fix integration with Worker settings is dict Fix(Arq): fix integration with Worker settings as a dict Nov 5, 2024
sl0thentr0py
sl0thentr0py requested changes Nov 6, 2024
View reviewed changes
sl0thentr0py and others added 3 commits November 6, 2024 17:30
@sl0thentr0py
Update tests/integrations/arq/test_arq.py

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
6b63496
@sl0thentr0py
Merge branch 'master' into fix-arq-dic-settings

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
0a5d17a
@sl0thentr0py
Remove typing from test
Loading
Loading status checks…
2432c5f
@sl0thentr0py sl0thentr0py added the Trigger: tests using secrets PR code is safe; run CI label Nov 6, 2024
sl0thentr0py
sl0thentr0py approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@sl0thentr0py sl0thentr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty @saber-solooki makes sense!

@codecov Codecov
Copy link

codecov bot commented Nov 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.38%. Comparing base (24e5359) to head (2432c5f).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3742   +/-   ##
=======================================
  Coverage   84.37%   84.38%           
=======================================
  Files         136      136           
  Lines       14370    14375    +5     
  Branches     2417     2422    +5     
=======================================
+ Hits        12125    12130    +5     
  Misses       1495     1495           
  Partials      750      750
Files with missing lines Coverage Δ
sentry_sdk/integrations/arq.py 91.80% <100.00%> (+0.35%) ⬆️

... and 2 files with indirect coverage changes

@sl0thentr0py sl0thentr0py merged commit c2dfbcc into getsentry:master Nov 6, 2024
136 of 139 checks passed
@MarcDufresne MarcDufresne mentioned this pull request Nov 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sl0thentr0py sl0thentr0py

Assignees
No one assigned
Labels
Trigger: tests using secrets PR code is safe; run CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Arq integration fails when worker setting is dict
2 participants
@saber-solooki @sl0thentr0py