Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Disable broken RQ test in newly-released RQ 2.0 #3708

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

szokeasaurusrex
Copy link
Member

See #3707

See #3707
@szokeasaurusrex szokeasaurusrex enabled auto-merge (squash) October 28, 2024 16:37
@@ -35,6 +35,7 @@ def _patch_rq_get_server_version(monkeypatch):


def crashing_job(foo):
print("RUNNING CRASHING JOB")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove print

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.28%. Comparing base (b6482f0) to head (fd7a9ca).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3708   +/-   ##
=======================================
  Coverage   84.28%   84.28%           
=======================================
  Files         133      133           
  Lines       14257    14257           
  Branches     2405     2405           
=======================================
  Hits        12017    12017           
  Misses       1490     1490           
  Partials      750      750           

see 4 files with indirect coverage changes

@szokeasaurusrex szokeasaurusrex merged commit 4c1367b into master Oct 28, 2024
136 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/rq-disable-test branch October 28, 2024 16:51
szokeasaurusrex added a commit that referenced this pull request Oct 29, 2024
#3708 got auto-merged before I had the chance to remove this print statement.
szokeasaurusrex added a commit that referenced this pull request Oct 29, 2024
#3708 got auto-merged before I had the chance to remove this print statement.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants