Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(quart): Fix Quart integration #3043

Merged
merged 1 commit into from
May 3, 2024

Conversation

szokeasaurusrex
Copy link
Member

The Quart integration was completely broken prior to this commit, as it caused every request to fail with a 500 error. The reason was that we were using the non-async ensure_integration_enabled decorator on the async sentry_patched_asgi_app function. This commit fixes the issue by removing the use of that decorator, instead replacing it with a manual check for the integration being enabled.

Fixes GH-3040

The Quart integration was completely broken prior to this commit, as it caused every request to fail with a 500 error. The reason was that we were using the non-async `ensure_integration_enabled` decorator on the async `sentry_patched_asgi_app` function. This commit fixes the issue by removing the use of that decorator, instead replacing it with a manual check for the integration being enabled.
@szokeasaurusrex
Copy link
Member Author

It is very surprising that our test suite did not detect that this integration was completely broken. Perhaps, this is a limitation of the Quart test_client we use in testing. We should certainly add tests to make sure we do not break in this way again, but that can likely be done later, most important is to quickly fix the broken integration ASAP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Quart] sentry_patched_asgi_app() missing 1 required positional argument: 'send'
2 participants