Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add queue or topic to Celery transactions/spans #2961

Open
1 of 2 tasks
Tracked by #2959
szokeasaurusrex opened this issue Apr 10, 2024 · 1 comment · May be fixed by #2984
Open
1 of 2 tasks
Tracked by #2959

Add queue or topic to Celery transactions/spans #2961

szokeasaurusrex opened this issue Apr 10, 2024 · 1 comment · May be fixed by #2984
Assignees
@szokeasaurusrex
Labels
enhancement New feature or request Feature: Performance Integration: Celery

Comments

@szokeasaurusrex
Copy link
Member

szokeasaurusrex commented Apr 10, 2024 •
edited

The queue should be sent with the producer span and the consumer transaction according to the Otel Specs. We first need to figure out how to obtain the queue.

Tasks
Beta Give feedback
  1. feat(celery): Send queue name to Sentry #2984
    szokeasaurusrex
@szokeasaurusrex szokeasaurusrex mentioned this issue Apr 10, 2024
Open
@szokeasaurusrex szokeasaurusrex changed the title **queue or topic (messaging.destination.name) - not sure where to get this**. queue or topic (messaging.destination.name) - not sure where to get this**. Apr 10, 2024
@szokeasaurusrex szokeasaurusrex changed the title queue or topic (messaging.destination.name) - not sure where to get this**. Add queue or topic to Celery transactions/spans Apr 10, 2024
@szokeasaurusrex szokeasaurusrex self-assigned this Apr 10, 2024
@szokeasaurusrex
Copy link
Member Author

Logic for setting data needed to route to correct queue in the producer side. From here, it seems that the producer only sometimes will know the queue; in other cases, the broker determines the queue.

https://github.com/celery/celery/blob/481cf8e19ca2b5d34eb74a6954974e9dc92ebda3/celery/app/task.py#L622-L645

The question, therefore, is whether we can determine the queue on the consumer side.

szokeasaurusrex added a commit that referenced this issue Apr 16, 2024
@szokeasaurusrex
feat(celery): Send queue name to sentry_sdk
41a0d6c 
Send the queue name to Sentry for Celery tasks using the default exchange. The queue name is sent as span data with the key `messaging.destination.name`.

Ref GH-2961
@szokeasaurusrex szokeasaurusrex linked a pull request Apr 16, 2024 that will close this issue
Open
szokeasaurusrex added a commit that referenced this issue Apr 17, 2024
@szokeasaurusrex
feat(celery): Send queue name to sentry_sdk
d7b64e0 
Send the queue name to Sentry for Celery tasks using the default exchange. The queue name is sent as span data with the key `messaging.destination.name`.

Ref GH-2961
szokeasaurusrex added a commit that referenced this issue Apr 17, 2024
@szokeasaurusrex
feat(celery): Send queue name to sentry_sdk
759bd53 
Send the queue name to Sentry for Celery tasks using the default exchange. The queue name is sent as span data with the key `messaging.destination.name`.

Ref GH-2961
szokeasaurusrex added a commit that referenced this issue Apr 17, 2024
@szokeasaurusrex
feat(celery): Send queue name to Sentry
0e3c823 
Send the queue name to Sentry for Celery tasks using the default exchange. The queue name is sent as span data with the key `messaging.destination.name`.

Ref GH-2961
szokeasaurusrex added a commit that referenced this issue Apr 24, 2024
@szokeasaurusrex
feat(celery): Send queue name to Sentry
f941370 
Send the queue name to Sentry for Celery tasks using the default exchange. The queue name is sent as span data with the key `messaging.destination.name`.

Ref GH-2961
szokeasaurusrex added a commit that referenced this issue Apr 24, 2024
@szokeasaurusrex
feat: Send Celery retry count
3632f5c 
Ref #2961
szokeasaurusrex added a commit that referenced this issue Apr 24, 2024
@szokeasaurusrex
feat: Send Celery retry count
8a657d8 
Ref #2961
szokeasaurusrex added a commit that referenced this issue Apr 24, 2024
@szokeasaurusrex
feat: Send Celery retry count
ef03803 
Ref #2961
szokeasaurusrex added a commit that referenced this issue Apr 24, 2024
@szokeasaurusrex
feat: Send Celery retry count
5abdf3b 
Ref #2961
szokeasaurusrex added a commit that referenced this issue Apr 26, 2024
@szokeasaurusrex
feat(celery): Send queue name to Sentry
31c0f84 
Send the queue name to Sentry for Celery tasks using the default exchange. The queue name is sent as span data with the key `messaging.destination.name`.

Ref GH-2961
szokeasaurusrex added a commit that referenced this issue Apr 26, 2024
@szokeasaurusrex
feat: Send Celery retry count
df5d7f2 
Ref #2961
szokeasaurusrex added a commit that referenced this issue Apr 30, 2024
@szokeasaurusrex
feat(celery): Send queue name to Sentry
a70685e 
Send the queue name to Sentry for Celery tasks using the default exchange. The queue name is sent as span data with the key `messaging.destination.name`.

Ref GH-2961
szokeasaurusrex added a commit that referenced this issue Apr 30, 2024
@szokeasaurusrex
feat: Send Celery retry count
5f3298e 
Ref #2961
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szokeasaurusrex szokeasaurusrex

Labels
enhancement New feature or request Feature: Performance Integration: Celery
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(celery): Send queue name to Sentry getsentry/sentry-python
1 participant
@szokeasaurusrex