Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(transport): Expose socket_options #2786

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Mar 4, 2024

The urllib3 defaults for socket_options work fine most of the time, but there are environments and setups where they need tweaking (e.g., enabling keep-alive). One can create a custom transport with this, but given how often users need to tweak these, it makes sense to promote this to an init option.

Docs: getsentry/sentry-docs#9332

Closes #2391


General Notes

Thank you for contributing to sentry-python!

Please add tests to validate your changes, and lint your code using tox -e linters.

Running the test suite on your PR might require maintainer approval. Some tests (AWS Lambda) additionally require a maintainer to add a special label to run and will fail if the label is not present.

For maintainers

Sensitive test suites require maintainer review to ensure that tests do not compromise our secrets. This review must be repeated after any code revisions.

Before running sensitive test suites, please carefully check the PR. Then, apply the Trigger: tests using secrets label. The label will be removed after any code changes to enforce our policy requiring maintainers to review all code revisions before running sensitive tests.

@sentrivana sentrivana marked this pull request as ready for review March 5, 2024 10:53
@sentrivana sentrivana merged commit c5785fb into master Mar 5, 2024
122 of 123 checks passed
@sentrivana sentrivana deleted the ivana/expose-socket-options branch March 5, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose socket_options for transport
2 participants