Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Fix yaml generation script #2695

Merged
merged 1 commit into from Feb 1, 2024
Merged

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Feb 1, 2024

The generation script -- when run with --fail-on-changes -- was supposed to raise an error if it detected that the integration test YAML files have changed but haven't been committed. The check is based on a hash of the contents of the YAML files, but there was a typo in the file names to consider (integration -> integrations), so it wasn't actually looking at any files and was always trivially true.

Now it'll properly complain if changes are made to tox.ini or to some of the constants in the splitting script that result in new YAML files, but those are not part of the commit.


General Notes

Thank you for contributing to sentry-python!

Please add tests to validate your changes, and lint your code using tox -e linters.

Running the test suite on your PR might require maintainer approval. Some tests (AWS Lambda) additionally require a maintainer to add a special label to run and will fail if the label is not present.

For maintainers

Sensitive test suites require maintainer review to ensure that tests do not compromise our secrets. This review must be repeated after any code revisions.

Before running sensitive test suites, please carefully check the PR. Then, apply the Trigger: tests using secrets label. The label will be removed after any code changes to enforce our policy requiring maintainers to review all code revisions before running sensitive tests.

@sentrivana sentrivana merged commit ad86d61 into master Feb 1, 2024
123 checks passed
@sentrivana sentrivana deleted the ivana/fix-yaml-generation branch February 1, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants