Skip to content

feat(metrics): Make metrics work with gevent #2694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Feb 6, 2024
Merged

feat(metrics): Make metrics work with gevent #2694

merged 18 commits into from
Feb 6, 2024
+113 −82

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Jan 31, 2024 •
edited
Loading

@sentrivana
Remove is_gevent() check
Loading
Loading status checks…
771791b
@sentrivana
run metrics tests with gevent

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
a4a30a6
@sentrivana
wip

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
f4478dd
@sentrivana
wip

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
1242785
@sentrivana
wip

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
e72365a
@sentrivana
wip

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
d0af091
@sentrivana
trying something

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
0e9ae8e
@sentrivana
Merge branch 'master' into ivana/make-metrics-work-with-gevent

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
0aa042e
Zylphrex
Zylphrex previously approved these changes Feb 1, 2024
View reviewed changes
@sentrivana
wip

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
47ed0de
@sentrivana
maybe fix 2.7

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
577757d
@sentrivana
fix lint

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
89868f5
@sentrivana sentrivana changed the title fix(metrics): Make metrics work with gevent feat(metrics): Make metrics work with gevent Feb 2, 2024
@sentrivana
comment

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
f622c0b
@sentrivana
mypy

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
9c06d24
@sentrivana sentrivana marked this pull request as ready for review February 2, 2024 17:43
antonpirker
antonpirker approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@sentrivana
switch to contextvar

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
9277f31
@sentrivana
remove join()

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
1a747a1
@sentrivana
better naming

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
50db9bc
@sentrivana
Merge branch 'master' into ivana/make-metrics-work-with-gevent

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
7709a5e
@sentrivana
Copy link
Contributor Author

@antonpirker Rewrote this to use ContextVar instead of threading.local if you want to take another look

antonpirker
antonpirker approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@sentrivana
Merge branch 'master' into ivana/make-metrics-work-with-gevent

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
b5fe43e
@sentrivana sentrivana merged commit e9d7b73 into master Feb 6, 2024
@sentrivana sentrivana deleted the ivana/make-metrics-work-with-gevent branch February 6, 2024 09:52
@sentrivana sentrivana linked an issue Feb 6, 2024 that may be closed by this pull request
Make metrics work with gevent #2689
Closed
@sentrivana sentrivana mentioned this pull request Feb 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonpirker antonpirker

@Zylphrex Zylphrex

@szokeasaurusrex szokeasaurusrex

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make metrics work with gevent
3 participants
@sentrivana @antonpirker @Zylphrex