Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(metrics): Make metrics work with gevent #2694

Merged
merged 18 commits into from Feb 6, 2024
Merged

feat(metrics): Make metrics work with gevent #2694

merged 18 commits into from Feb 6, 2024

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Jan 31, 2024 •
edited

Zylphrex
Zylphrex previously approved these changes Feb 1, 2024
View reviewed changes
@sentrivana sentrivana changed the title fix(metrics): Make metrics work with gevent feat(metrics): Make metrics work with gevent Feb 2, 2024
@sentrivana sentrivana marked this pull request as ready for review February 2, 2024 17:43
antonpirker
antonpirker approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@sentrivana
Copy link
Contributor Author

@antonpirker Rewrote this to use ContextVar instead of threading.local if you want to take another look

antonpirker
antonpirker approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@sentrivana sentrivana merged commit e9d7b73 into master Feb 6, 2024
119 of 121 checks passed
@sentrivana sentrivana deleted the ivana/make-metrics-work-with-gevent branch February 6, 2024 09:52
@sentrivana sentrivana linked an issue Feb 6, 2024 that may be closed by this pull request
Make metrics work with gevent #2689
Closed
@sentrivana sentrivana mentioned this pull request Feb 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonpirker antonpirker antonpirker approved these changes

@Zylphrex Zylphrex Zylphrex left review comments

@szokeasaurusrex szokeasaurusrex Awaiting requested review from szokeasaurusrex

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make metrics work with gevent
3 participants
@sentrivana @antonpirker @Zylphrex