Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ddm): Enable metrics related settings by default #2685

Merged
merged 13 commits into from Jan 30, 2024
Merged

feat(ddm): Enable metrics related settings by default #2685

merged 13 commits into from Jan 30, 2024

Conversation

iambriccardo
Copy link
Member

@iambriccardo iambriccardo commented Jan 29, 2024 •
edited

This PR enables metrics by default, metrics summaries with a sample rate of 1.0, and code locations by default.

Closes: getsentry/sentry#64051

@iambriccardo iambriccardo marked this pull request as ready for review January 29, 2024 13:08
antonpirker
antonpirker approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@iambriccardo
Default other
66e29e4
@iambriccardo
Merge branch 'riccardo/feat/default-metric-summary-experiment' of git…
9592185 
…hub.com:getsentry/sentry-python into riccardo/feat/default-metric-summary-experiment
@iambriccardo iambriccardo changed the title feat(ddm): Enable metrics summaries by default feat(ddm): Enable metrics related settings by default Jan 29, 2024
@iambriccardo iambriccardo enabled auto-merge (squash) January 29, 2024 15:36
@antonpirker
Copy link
Member

@mitsuhiko the tests for the transport using eventlet or greenlet time out because of some deadlock when we send 100% metrics: https://github.com/getsentry/sentry-python/actions/runs/7698573390/job/20978166097?pr=2685

Do you have an idea why this is happening?

@antonpirker
Copy link
Member

After some digging: The problem is that the MetricsAggregator does not work with gevent. We need to update it to make it work with gevent, similar to what the profiler does: https://github.com/getsentry/sentry-python/blob/master/sentry_sdk/profiler.py

This was referenced Jan 30, 2024
Merged
Closed
@sentrivana
Disable metrics if gevent is used (#2688)
329a647 
Enabling metrics by default leads to a deadlock when gevent is installed. For now, we will disable metrics when gevent is used. In the next step, we'll make metrics work with gevent.
antonpirker
antonpirker approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should work now with ivanas fix

@iambriccardo iambriccardo merged commit eee728c into master Jan 30, 2024
123 checks passed
@iambriccardo iambriccardo deleted the riccardo/feat/default-metric-summary-experiment branch January 30, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitsuhiko mitsuhiko mitsuhiko approved these changes

@antonpirker antonpirker antonpirker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable metrics summaries by default in python SDK
4 participants
@iambriccardo @antonpirker @mitsuhiko @sentrivana