Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to new style type hints #2585

Open
sentrivana opened this issue Dec 12, 2023 · 0 comments · May be fixed by #2678
Open

Switch to new style type hints #2585

sentrivana opened this issue Dec 12, 2023 · 0 comments · May be fixed by #2678
Assignees
Labels
enhancement New feature or request SDK 2.0

Comments

@sentrivana
Copy link
Contributor

sentrivana commented Dec 12, 2023

Problem Statement

Once we've removed support for EOL Python versions, we can migrate our type hints from comments to new-style typing hints.

Solution Brainstorm

  • research tools to do this automatically
  • if there is no tool or it doesn't work great for us, start a gradual rewrite and come up with a plan (e.g. everyone who touches a function needs to update its typing hints, etc.)
@sentrivana sentrivana added enhancement New feature or request SDK 2.0 labels Dec 12, 2023
@sentrivana sentrivana added this to the Sentry SDK 2.0 milestone Dec 12, 2023
@sentrivana sentrivana self-assigned this Jan 26, 2024
@sentrivana sentrivana linked a pull request Jan 26, 2024 that will close this issue
@sentrivana sentrivana removed this from the Sentry SDK 2.0 milestone Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request SDK 2.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant