Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query-source): Fix query source duration check #2675

Merged
merged 11 commits into from Jan 29, 2024

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Jan 25, 2024

We were sometimes not adding query source to DB spans that took much longer than db_query_source_threshold_ms.

The SDK was considering some long spans to be too short because we were using timedelta.microseconds to find out the span duration. timedelta.microseconds doesn't return the whole duration in microseconds, just the microsecond part:

>>> from datetime import timedelta
>>> t = timedelta(days=50, microseconds=10)
>>> t.microseconds
10
>>> t / timedelta(microseconds=1)
4320000000010.0

General Notes

Thank you for contributing to sentry-python!

Please add tests to validate your changes, and lint your code using tox -e linters.

Running the test suite on your PR might require maintainer approval. Some tests (AWS Lambda) additionally require a maintainer to add a special label to run and will fail if the label is not present.

For maintainers

Sensitive test suites require maintainer review to ensure that tests do not compromise our secrets. This review must be repeated after any code revisions.

Before running sensitive test suites, please carefully check the PR. Then, apply the Trigger: tests using secrets label. The label will be removed after any code changes to enforce our policy requiring maintainers to review all code revisions before running sensitive tests.

@sentrivana sentrivana self-assigned this Jan 25, 2024
@sentrivana sentrivana marked this pull request as ready for review January 26, 2024 11:53
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, what an embarrassing bug. Thanks for the great fix!

@sentrivana
Copy link
Contributor Author

Oh, what an embarrassing bug. Thanks for the great fix!

The timedelta API is really not great here. Had us both fooled 🙃

@sentrivana sentrivana merged commit 1a9225c into master Jan 29, 2024
123 checks passed
@sentrivana sentrivana deleted the ivana/fix-query-source-timing branch January 29, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants