New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(integrations): Add support for celery-redbeat cron tasks #2643
feat(integrations): Add support for celery-redbeat cron tasks #2643
Conversation
e86d569
to
9b08b0e
Compare
Thanks a lot @kwigley! We will take a look. |
9b08b0e
to
bdaa390
Compare
6aea603
to
28b3504
Compare
28b3504
to
0d9f0d6
Compare
0d9f0d6
to
c0d15c9
Compare
Hey @kwigley, sorry for the wait. I've tried the PR but it doesn't work for me -- did it work for you? As far as I can tell the problem is we attempt to patch the |
Ok it was a problem with my setup (and our docs :) ) -- I'm getting monitors now. Will give the PR one more look but looks good at first glance! |
ah, missed your previous comment. Sounds good! lmk if you need anything else |
@kwigley All good, no action needed on your end, this is good to merge. Thank you! |
This add support for celery-redbeat (resolves #2616). Thanks to #2616 (comment)
General Notes
Thank you for contributing to
sentry-python
!Please add tests to validate your changes, and lint your code using
tox -e linters
.Running the test suite on your PR might require maintainer approval. Some tests (AWS Lambda) additionally require a maintainer to add a special label to run and will fail if the label is not present.
For maintainers
Sensitive test suites require maintainer review to ensure that tests do not compromise our secrets. This review must be repeated after any code revisions.
Before running sensitive test suites, please carefully check the PR. Then, apply the
Trigger: tests using secrets
label. The label will be removed after any code changes to enforce our policy requiring maintainers to review all code revisions before running sensitive tests.